Source Railz: Migrate to manifest-only format #47244
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
/format-fix
|
|
All checks passed! |
|
/format-fix
|
…q/airbyte into btkcodedev/railzMigrate
|
/format-fix
|
|
@btkcodedev looks nice, but as I can see we still have components file but unit tests were removed? |
|
The freezegun package from freeze time is shown as not found. I've tried to add and it was already in the failing category. @DanyloGL |
…q/airbyte into btkcodedev/railzMigrate
|
@DanyloGL I tried to import freezegun, Error: unit_tests/test_components.py:5: in <module>
from freezegun import freeze_time
E ModuleNotFoundError: No module named 'freezegun'But I could clearly see it is there in my pyproject.toml and poetry.lock |
|
What do you want me to do as next step? |
|
Or if the shortlivedcomponent bearer token test is not necessary we could remove it. |
| @@ -20,6 +20,7 @@ python = "^3.9,<3.12" | |||
| airbyte-cdk = "^0" | |||
There was a problem hiding this comment.
@btkcodedev I think this is the problem — this has to be a more recent version, go for ^6.
| @@ -29,3 +30,8 @@ pytest-mock = "^3.6.1" | |||
| requests-mock = "^1.9.3" | |||
| pytest = "^6.2" | |||
There was a problem hiding this comment.
You don't need it here anymore, I would remove it. Or update to pytest 6. I think you can remove the whole section for dev dependencies.
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11026
Source Railz: Migrate to manifest-only formats with components
How
Migrated to inline schemas
Migrated spec
Migrated to manifest only with ci
Migration report