Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A/C Performance abstract class + graph improvement #453

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

nestorcarmona
Copy link
Contributor

Contains:

  • A/C Performance abstract class: modular interface for any A/C perf model
  • OpenAP and Poll-Schumann updated code + test fix
  • Input graph improvement (networkx) with climb/descent speeds and mach cruise

@fteicht fteicht self-assigned this Dec 20, 2024
@fteicht fteicht added bug Something isn't working enhancement New feature or request labels Dec 20, 2024
Copy link
Collaborator

@fteicht fteicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @nestorcarmona for the impressive and great work!
Can you please remove the commented code (not the documentation/explanation comments), and even files which are entirely commented like test_aircraft_perf_model.py? If needed, old code can be retrieved by navigating previous commits. Thanks in advance!

@nestorcarmona
Copy link
Contributor Author

@fteicht Thank you Florent! Just did some code and file cleanup as requested

@fteicht fteicht merged commit 02f54a1 into airbus:master Dec 20, 2024
27 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants