fix content offset adjustment for bounds changing #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
For the bottomToTop layout, the y offset adjustment
max(currentCollectionView.bounds.height - newBounds.height + contentInset.bottom, 0)
is not right. we should not involve thecontentInset.bottom
.The iOS system will help adjust the yOffset when new bounds exceed the boundary. It means we should check
if newBounds.maxY < currentCollectionView.contentSize.height + contentInset.bottom
as well.Motivation and Context
We are building an messaging screen for Airbnb and I find this issue causes the message cells jumping when typing indicator hide and show.
How Has This Been Tested
I built a small sample to test this case.
Before this change: The cells move up every time the bounds changed.
After the change: The cells keep bottom spacing the same.
Types of changes
Checklist