Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature (interpreted functions) #626

Open
wants to merge 156 commits into
base: master
Choose a base branch
from

Conversation

Ezpeon
Copy link

@Ezpeon Ezpeon commented Sep 11, 2024

Not supported:

  • interpreted function in the problem goal

Untested:

  • UserType as function output - might work but has not been tested
  • conversion of partial order plans and STN plans with interpreted functions has not been tested

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 96.11307% with 55 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (7b1a737) to head (56cbda1).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...engines/compilers/interpreted_functions_remover.py 95.86% 18 Missing ⚠️
unified_planning/model/interpreted_function.py 90.24% 12 Missing ⚠️
..._planning/engines/interpreted_functions_planner.py 91.12% 11 Missing ⚠️
unified_planning/engines/compilers/utils.py 70.00% 3 Missing ⚠️
..._planning/model/walkers/usertype_fluents_walker.py 25.00% 3 Missing ⚠️
unified_planning/model/walkers/type_checker.py 77.77% 2 Missing ⚠️
unified_planning/shortcuts.py 50.00% 2 Missing ⚠️
unified_planning/model/expression.py 93.33% 1 Missing ⚠️
unified_planning/model/problem.py 93.33% 1 Missing ⚠️
unified_planning/model/walkers/names_extractor.py 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   85.36%   85.92%   +0.55%     
==========================================
  Files         202      209       +7     
  Lines       27319    28726    +1407     
==========================================
+ Hits        23322    24682    +1360     
- Misses       3997     4044      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Samuel Gobbi added 29 commits October 15, 2024 11:23
…nml cannot handle these test cases as of now
…yer of ands in preconditions for instantaneous actions
Copy link
Member

@alvalentini alvalentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ezpeon I left a few comments

unified_planning/engines/results.py Outdated Show resolved Hide resolved
unified_planning/model/walkers/simplifier.py Outdated Show resolved Hide resolved
unified_planning/engines/sequential_simulator.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/model/walkers/quantifier_simplifier.py Outdated Show resolved Hide resolved
unified_planning/engines/interpreted_functions_planner.py Outdated Show resolved Hide resolved
unified_planning/engines/interpreted_functions_planner.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/engines/plan_validator.py Outdated Show resolved Hide resolved
unified_planning/model/expression.py Outdated Show resolved Hide resolved
unified_planning/model/walkers/quantifier_simplifier.py Outdated Show resolved Hide resolved
unified_planning/model/walkers/simplifier.py Outdated Show resolved Hide resolved
unified_planning/model/walkers/simplifier.py Outdated Show resolved Hide resolved
unified_planning/shortcuts.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants