Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write rules. #79

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Fix write rules. #79

merged 4 commits into from
Dec 11, 2023

Conversation

yoojinko
Copy link
Collaborator

@yoojinko yoojinko commented Dec 6, 2023

Write rule 변경되었습니다.

  • root: app 생성시 기본적으로 admin 만 write하도록 설정되어 따로 룰 세팅하지 않도록 변경하였습니다.
  • request: minCost === 0 일 때 user balance가 없어도 write 할 수 있도록 변경하였습니다.

그 외

  • readme 오기 수정하였습니다.

akastercomcom
akastercomcom approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@akastercomcom akastercomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@yoojinko
Copy link
Collaborator Author

Thanks for the review!

@yoojinko yoojinko merged commit 6223b50 into develop Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akastercomcom akastercomcom akastercomcom approved these changes

@dev2l0per dev2l0per Awaiting requested review from dev2l0per

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoojinko @akastercomcom