Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specific api filter #72

Merged
merged 2 commits into from
Nov 3, 2023
Merged

specific api filter #72

merged 2 commits into from
Nov 3, 2023

Conversation

akastercomcom
Copy link
Collaborator

특정 api 안에서 trigger filter를 걸 수 있는 메소드를 추가했습니다.

Copy link
Collaborator

@yoojinko yoojinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment, Thanks!

* @returns Null if if request is duplicated.
*/
triggerFilter = (req: Request, res: Response) => {
if (req.body.fid === undefined){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor) if문 하나로 합치는건 어떨까요?

if (!fid || !transaction)

@akastercomcom
Copy link
Collaborator Author

thanks!
now merged!

@akastercomcom akastercomcom merged commit 1df7b27 into develop Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants