Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: model run and stop #59

Merged
merged 2 commits into from
Sep 22, 2023
Merged

feat: model run and stop #59

merged 2 commits into from
Sep 22, 2023

Conversation

akastercomcom
Copy link
Collaborator

  • isLoggedIn 체크를 modelController에서 하던 방법을 model에서 하는 방법으로 바꿨습니다.
  • isAdmin 메소드를 구현했습니다.
  • run, stop 메소드를 구현했습니다.

yoojinko
yoojinko approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@yoojinko yoojinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment. Thanks!

src/controllers/modelController.ts
const adminPath = Path.app(modelName);
const adminList = await this.ain.getValue(adminPath);
if(!adminList[this.ain.getAddress()]) {
throw new Error('You are not admin');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor) admin. ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

@akastercomcom
Copy link
Collaborator Author

Thanks!
now merged!

@akastercomcom akastercomcom merged commit c71ee0a into develop Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoojinko yoojinko yoojinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akastercomcom @yoojinko