Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ainize doc #57

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Add ainize doc #57

merged 4 commits into from
Sep 21, 2023

Conversation

yoojinko
Copy link
Collaborator

ainize.ts 에 tsdoc 추가했습니다.

Copy link
Collaborator

@akastercomcom akastercomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments Thanks!
조금 자연스러워 보이는 표현들을 추천드렸습니다.

src/ainize.ts Outdated
return AinModule.getInstance().createAccount();
}

/**
* Login of the ainize using AI Network account private key.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login to ainize using ~ 이 조금 더 자연스러운 표현 같습니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

src/ainize.ts Outdated
async login(privateKey: string) {
this.ain.setDefaultAccount(privateKey);
await this.handler.connect();
console.log('login success! address:', this.ain.getAddress());
}

/**
* Logout of the ainize.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logout from ainize?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

src/ainize.ts Outdated
@@ -48,11 +60,17 @@ export default class Ainize {
}

// FIXME(yoojin): add config type and change param type.
/**
* Deploy AI model container.
* @param {deployConfig} deployConfig Set configuration for container. modelName, billingConfig, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configurations for setting container.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

src/ainize.ts Outdated
/**
* Deploy AI model container.
* @param {deployConfig} deployConfig Set configuration for container. modelName, billingConfig, etc.
* @returns {Model} Control object of deployed model.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed Model Object?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

src/ainize.ts Outdated
/**
* Get deployed model.
* @param modelName
* @returns {Model} Control object of deployed model.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@yoojinko
Copy link
Collaborator Author

Thanks for the review!

@yoojinko yoojinko merged commit 8476ab1 into develop Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants