Add deploy config and set contaner status #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akastercomcom
approved these changes
Sep 19, 2023
src/types/type.ts
Outdated
| modelName: string, | ||
| billingConfig?: appBillingConfig, | ||
| serviceUrl?: string, |
There was a problem hiding this comment.
현재는 serviceUrl필수로 해두는게 맞는 것 같습니다.
There was a problem hiding this comment.
저희 테스트 용으로 임시로 두었습니다. logic에는 주석 썼는데 type에 안써놨네요. 주석 추가하겠습니다.
| } | ||
| } | ||
| // NOTE(yoojin): For test. We make fixed url on service. | ||
| if (!serviceUrl) { |
There was a problem hiding this comment.
현재로썬 저 규칙을 안따를 가능성이 높기 때문에 그냥 필수로 하는게 더 좋아 보입니다.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy config 추가하여 config data 로 app 생성하도록 변경하였습니다.
setContainerStatus 추가하였습니다.