refactor: delete serviceName #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoojinko
approved these changes
Sep 18, 2023
src/modules/admin.ts
Outdated
| @@ -57,7 +57,6 @@ export default class Admin extends ModuleBase { | |||
| } | |||
| const requestData: request = { | |||
| appName: req.body.valuePath[1], | |||
| serviceName: req.body.valuePath[3], | |||
| requesterAddress: req.body.auth.addr, | |||
| requestKey: req.body.valuePath[5], | |||
There was a problem hiding this comment.
path가 짧아짐에 따라 requestKey도 valuePath[4] 로 변경되어야할까요?
src/modules/app.ts
Outdated
| value: { | ||
| ".rule": { | ||
| write: | ||
| "auth.addr === $userAddress && getValue(`/apps/" + `${appName}` + "/balance/` + $userAddress + `/balance`) !== null && " + | ||
| "(!util.isEmpty(getValue(`/apps/" + `${appName}` + "/billingConfig/` + $serviceName + `/minCost`))) && (getValue(`/apps/" + `${appName}` + "/balance/` + $userAddress + `/balance`) >= getValue(`/apps/" + `${appName}` + "/billingConfig/` + $serviceName + `/minCost`)) || " + | ||
| "(!util.isEmpty(getValue(`/apps/" + `${appName}` + "/billingConfig/minCost`))) && (getValue(`/apps/" + `${appName}` + "/balance/` + $userAddress + `/balance`) >= getValue(`/apps/" + `${appName}` + "/billingConfig/minCost`)) || " + | ||
| "getValue(`/apps/" + `${appName}` + "/balance/` + $userAddress + `/balance`) >= getValue(`/apps/" + `${appName}` + "/billingConfig/service/default/minCost`)" |
There was a problem hiding this comment.
240줄 끝의 || 부터 241줄 전체 지워지면 좋을 것 같습니다.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceName을 사용하는 코드들을 수정했습니다.
rule 부분 확인 부탁드립니다.