-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AINFT contract template #1
base: develop
Are you sure you want to change the base?
Conversation
dffd9c9
to
a0c29a1
Compare
feat: AINFT contract template structure impl.
a0c29a1
to
24861dd
Compare
); | ||
|
||
baseURI = newBaseURI; | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should emit BatchMetadataUpdate(start, end)
with counter's help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered it before. However the setBaseURI()
call occurs after the someone calls updateTokenURI()
, the baseURI could be ignored when calling tokenURI()
. I will leave it behind, with remaining TODO comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MetadataUpdate
/ BatchMetadataUpdate
is for the NFT marketplaces or other 3rd parties, so I think this should be emitted on here.
If not, we don't have to implement the ERC-4906 at first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of ERC721 contracts set the baseURI
in initialization phase and no implementation for setBaseURI()
. In the perspective of structuring the base template, setBaseURI()
don't need to be necessary. However, the versioning of metadata is important concept of template and it'd better to put ERC4906 inside the template.
As a alternative way, I'm trying to add pre-condition check of setBaseURI()
: if the number of having been called updateTokenURI()
is equal or more than once, setBaseURI()
cannot be executed. In this case, the BatchMetadataUpdate
can be added.
What do you think of this way?
feat: AINFT contract template structure implementation
deploy
test