Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search response type #218

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix search response type #218

merged 2 commits into from
Oct 16, 2023

Conversation

woomurf
Copy link
Member

@woomurf woomurf commented Oct 12, 2023

Fix search response type

// AS-IS
{
  list: [],
  isFinal: boolean,
  nextOffset: string
}

// TO-BE
{
  nfts | ainftObjects: [],
  isFinal: boolean,
  cursor: string
}

platfowner
platfowner approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@platfowner platfowner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@woomurf
Copy link
Member Author

woomurf commented Oct 16, 2023

Thanks for the review!

@woomurf woomurf merged commit c02b6bd into develop Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platfowner platfowner platfowner approved these changes

@shyun-comcom shyun-comcom Awaiting requested review from shyun-comcom

@ehgmsdk20 ehgmsdk20 Awaiting requested review from ehgmsdk20

@jiyoung-an jiyoung-an Awaiting requested review from jiyoung-an

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woomurf @platfowner