Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PEER_CANDIDATE_JSON_RPC_URL for onprem genesis testnet / mainnet #1321

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Set PEER_CANDIDATE_JSON_RPC_URL for onprem genesis testnet / mainnet #1321

merged 5 commits into from
Sep 10, 2024

Conversation

platfowner
Copy link
Member

Change summary:

  • Set PEER_CANDIDATE_JSON_RPC_URL for onprem genesis testnet / mainnet
  • Remove unsupported seasons from onprem deploy scripts
  • Update deploy script examples

Related issues:

@platfowner platfowner changed the title Feature/platfowner/feature Set PEER_CANDIDATE_JSON_RPC_URL for onprem genesis testnet / mainnet Sep 9, 2024
jiyoung-an
jiyoung-an approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@jiyoung-an jiyoung-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@platfowner
Copy link
Member Author

Thanks for the review! @jiyoung-an Now merging..

@platfowner platfowner force-pushed the feature/platfowner/feature branch from 28c504d to facf3f6 Compare September 10, 2024 02:31
@platfowner platfowner merged commit e3dc953 into develop Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoung-an jiyoung-an jiyoung-an approved these changes

@shyun-comcom shyun-comcom Awaiting requested review from shyun-comcom

@minho-comcom-ai minho-comcom-ai Awaiting requested review from minho-comcom-ai

@yoojinko yoojinko Awaiting requested review from yoojinko

@akastercomcom akastercomcom Awaiting requested review from akastercomcom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platfowner @jiyoung-an