Apply idle time check to event handler channels #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platfowner
requested review from
shyun-comcom,
yoojinko,
jiyoung-an,
minjaeli and
akastercomcom
jiyoung-an
reviewed
Aug 9, 2024
| } | ||
|
|
||
| handleConnection(webSocket) { | ||
| const LOG_HEADER = 'handleConnection'; | ||
| try { | ||
| if (this.getNumEventChannels() >= NodeConfigs.MAX_NUM_EVENT_CHANNELS) { | ||
| webSocket.terminate(); |
jiyoung-an
approved these changes
Aug 9, 2024
| const idleTimeMs = channel.getIdleTimeMs(); | ||
| if (idleTimeMs > NodeConfigs.EVENT_HANDLER_CHANNEL_IDLE_TIME_LIMIT_SECS * 1000) { | ||
| logger.info(`[${LOG_HEADER}] Closing long-idle channel: ${JSON.stringify(channel.toObject())}`); | ||
| channel.webSocket.terminate(); |
There was a problem hiding this comment.
It seems that the closeChannel method also calls webSocket.terminate().
There was a problem hiding this comment.
right. just removed. thanks!
| const lifeTimeMs = channel.getLifeTimeMs(); | ||
| if (lifeTimeMs > NodeConfigs.EVENT_HANDLER_CHANNEL_LIFE_TIME_LIMIT_SECS * 1000) { | ||
| logger.info(`[${LOG_HEADER}] Closing long-life channel: ${JSON.stringify(channel.toObject())}`); | ||
| channel.webSocket.terminate(); |
jiyoung-an
reviewed
Aug 9, 2024
|
Thanks for the fast review! @jiyoung-an Now merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
Related issues: