Chang2 builtins #1064
Merged
Chang2 builtins #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroProofs
force-pushed
the
chang2-builtins
branch
from
39417c6 to
cc36057
Compare
… mainnet and testnet
MicroProofs
force-pushed
the
chang2-builtins
branch
from
68c73ce to
91d4ecc
Compare
…re accurate shifting
KtorZ
reviewed
Dec 7, 2024
|
|
||
| let bit_offset = usize::try_from(bit_offset).unwrap(); | ||
|
|
||
| let flipped_index = bytes.len() - 1 - usize::try_from(byte_index).unwrap(); |
There was a problem hiding this comment.
Confusing as hell, but it's in the CIP. I am not sure why it was settled on reading bits from the end. We have to document that properly in the Prelude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.