Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian (Farsi) Locale Support #188

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Conversation

MohammadForoutan
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zod-i18n ✅ Ready (Inspect) Visit Preview Jan 8, 2024 7:54am

@aiji42
Copy link
Owner

aiji42 commented Jan 8, 2024

@MohammadForoutan Apologies for the delayed review. It seems like the tests are failing. Could you please check on this?

@aiji42
Copy link
Owner

aiji42 commented Jan 8, 2024

@MohammadForoutan The commit 5ab3260 (Revert "fix: remove .only in fa test cases") is unnecessary. .only should not be included.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4e0e3c) 100.00% compared to head (5546492) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          298       298           
  Branches        60        60           
=========================================
  Hits           298       298           
Flag Coverage Δ
core 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiji42
Copy link
Owner

aiji42 commented Jan 8, 2024

@MohammadForoutan Thank you for the prompt response. I will merge this PR and proceed with the release.

@all-contributors please add @MohammadForoutan for translation and test.

Copy link
Contributor

@aiji42

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @MohammadForoutan! 🎉

@aiji42 aiji42 merged commit cf63a5a into aiji42:main Jan 8, 2024
4 checks passed
Copy link

github-actions bot commented Jan 8, 2024

🎉 This PR is included in version zod-i18n-map-v2.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants