Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: various cleanups around examples and CI #33

Merged
merged 8 commits into from
Jan 9, 2024
Merged

CI: various cleanups around examples and CI #33

merged 8 commits into from
Jan 9, 2024

Conversation

aignas
Copy link
Owner

@aignas aignas commented Jan 9, 2024

Summary:

  • chore: fix typo and reuse the upstream constraint
  • chore: ignore MODULE.bazel.lock
  • chore: use latest bazel version by default
  • chore: use the latest platforms package
  • ci: do not test the released_example within CI
  • chore: remove bzlmod example
  • chore: add MODULE.bazel to remaining examples

@aignas aignas marked this pull request as ready for review January 9, 2024 04:17
@aignas aignas merged commit 938741f into master Jan 9, 2024
6 checks passed
@aignas aignas deleted the fix/ci branch January 9, 2024 04:18
stefanpenner
stefanpenner reviewed Jan 9, 2024
View reviewed changes
BUILD.bazel
constraint_value(
name = "armv6hf",
constraint_setting = ":cpu",
constraint_setting = "@platforms//cpu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BUILD.bazel
)

# rasberry pi
# Raspberry Pi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanpenner stefanpenner stefanpenner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aignas @stefanpenner