feat!: support generic inputs and outputs in controllers #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domire8 just about to write the corresponding issue and update the descriptions, but this is my draft for the time being. |
bpapaspyros
commented
Oct 3, 2024
domire8
reviewed
Oct 3, 2024
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
1 task
domire8
reviewed
Oct 4, 2024
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
domire8
reviewed
Oct 4, 2024
domire8
force-pushed
the
feat/generic_controller_outputs
branch
from
ec703d4
to
5307e2c
Compare
domire8
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for generic outputs in controllers. Similarly to #145, we use compile-time data type inference to make sure that custom (ROS) types are 1) added to the output map generically, 2) are directly published when
write_outputis invoked.Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: