Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devcontainer configuration #5

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: devcontainer configuration #5

merged 1 commit into from
Nov 6, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Oct 28, 2024

Description

Currently, opening the VS code devcontainer from the button in the README doesn't work because of the mount directive in the configuration. We can avoid the additional mount by just symlinking the workspace content to the ros2 workspace.

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@domire8 domire8 merged commit ff2b6cf into main Nov 6, 2024
2 checks passed
@domire8 domire8 deleted the fix/devcontainer branch November 6, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants