Microphysics tuning PR #177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g., factor = - fac_l2v * min (1., 10. * (1. - qv (i, j) / wqsat (i))) change it to factor = - fac_l2v * min (1., 1. * (1. - qv (i, j) / wqsat (i))) I will expect much larger cloud water change in this case because your relative humidity is very high.
This reverts commit 7a2b2b4.
This reverts commit 52118a1.
This reverts commit 7b39eb3.
the previous account had too personal of a name (nbren12).
This reverts commit f038d35. This had a minimal effect
Linjiongs changes made this a local variable in the gfdl microphysics suite. replace this reference with a local variable in fv_cmp.f90 WARNING only valid if fv_cmp.f90 is never used (e.g. do_sat_adj = false)
nixpkgs 20.09 doesn't support big sur. Use an older commit from nixpkgs-unstable instead.
Co-authored-by: Spencer Clark <[email protected]>
This reverts commit 8d097ee.
remove the temperature dependent denominator change the namelist option name
add a namelist option rh_factor
h_var is used to compute the saturation deficit for rain evaporation. This change was not suggested by Linjiong, but the 0.2 limit on h_var limits the utility of this parameter.
h_var still had little effect in the parent commit.
This reverts commit f1a238d. This had no effect
This reverts commit 9ec1005. this did not seem to have much effect.
| @@ -57,7 +57,7 @@ module fv_cmp_mod | |||
| use constants_mod, only: rvgas, rdgas, grav, hlv, hlf, cp_air | |||
| use fv_mp_mod, only: is_master | |||
| use fv_arrays_mod, only: r_grid | |||
| use gfdl_cloud_microphys_mod, only: ql_gen, qi_gen, qi0_max, ql_mlt, ql0_max, qi_lim, qs_mlt | |||
There was a problem hiding this comment.
@nbren12 This change should be removed.
Change the namelist variable name "rs_factor" to "ts_factor".
added parameters for ice snow and graupel sublimation
Add options:
- gfs_physics_nml.{cinpcrmx,cinpcrmn}
this was the one real code difference compared to master, the remaining changes simply parameterize constants.
This reverts commit 8eae741. Without this change the rain water becomes far too low.
Jongil suggested we remove the grid dependence of the convective timescale. The time scale is currently proportional to (1 + 1 / 75 km dx) Adjust the scaling to be (1 + timescale_grid_factor * dx) so we can use different grid scalings for coarse resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used for tuning the GFDL microphysics at C48 resolution.