Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

78 errors in return value of models json example #79

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

78 errors in return value of models json example #79

wants to merge 11 commits into from

Conversation

MaxenceGui
Copy link
Collaborator

@MaxenceGui MaxenceGui commented Apr 22, 2024 •
edited
Loading

  • Correct JSON errors in the example of nachet-model-documentation.md
  • Modify labelOccurence to better reflect our data

@MaxenceGui MaxenceGui linked an issue Apr 22, 2024 that may be closed by this pull request
Errors in Return value of models JSON example #78
Open
@MaxenceGui MaxenceGui force-pushed the 78-errors-in-return-value-of-models-json-example branch from f26e131 to b506cc7 Compare April 24, 2024 14:54
@MaxenceGui
Copy link
Collaborator Author

Took the opportunity of this issue to update the documentation for Nachet backend

@ibrahim-kabir, @RussellJimmies and @Francois-Werbrouck if you want to give it a quick review I will appreciate it

@MaxenceGui MaxenceGui marked this pull request as ready for review April 24, 2024 19:15
@MaxenceGui MaxenceGui requested a review from a team as a code owner April 24, 2024 19:15
@MaxenceGui MaxenceGui force-pushed the 78-errors-in-return-value-of-models-json-example branch from 485276a to 67506c1 Compare April 24, 2024 19:30
@MaxenceGui MaxenceGui self-assigned this Apr 25, 2024
ibrahim-kabir
ibrahim-kabir approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ibrahim-kabir ibrahim-kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. This will be useful for the next interns and for the team. Incredible work @MaxenceGui ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francois-Werbrouck Francois-Werbrouck Francois-Werbrouck approved these changes

@ibrahim-kabir ibrahim-kabir ibrahim-kabir approved these changes

@RussellJimmies RussellJimmies Awaiting requested review from RussellJimmies

Assignees

@sylvanie85 sylvanie85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in Return value of models JSON example
4 participants
@MaxenceGui @ibrahim-kabir @Francois-Werbrouck @sylvanie85