Add support for "macos_dark_titlebar_color" #1097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, unfortunately I don't have access to a mac right now, so I can't test it. Hopefully soon I will be able to test and merge this request. |
|
Great! Thanks for Sioyek and for making it easy to contribute to 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm back with a new pull request.
This introduces a new configuration variable called
macos_dark_titlebar_colorwhich sets the titlebar color to a color distinct from the one set formacos_titlebar_colorif custom or dark color mode is toggled. It is also changed upon system theme change.I'm not sure if it's the best solution but I want to be able to have a titlebar that matches my pdf background color and this makes it happen.
What do you think?
Best,
Isak