Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject sererless instance into emulator #16

Closed
wants to merge 2 commits into from
Closed

Inject sererless instance into emulator #16

wants to merge 2 commits into from

Conversation

bboure
Copy link

@bboure bboure commented Feb 26, 2019

Inject the serverless instance directly into the emulator.

See: little-bear-labs/aws-utils#92

Only to be merged after the above PR has been accepted, merged, and pushed in npm.

Also, the version of emulator should be updated in package.json

@bboure
Copy link
Author

bboure commented Feb 26, 2019

Theoretically, nothing breaks and all functionalities should work as before.
In addition to that, the following also works (this is not the case with the previous implementation).

sls offline start --stage staging

This is useful for example if you have environment variables per stage.

Any help testing this is welcome.

@bboure
Copy link
Author

bboure commented Feb 28, 2019

@aheissenberger since little-bear-labs/aws-utils#92 got merged, I updated the package here to make use of it.
This should fix many issues and improve loading time.

@aheissenberger
Copy link
Owner

all packages have been updated

@bboure
Copy link
Author

bboure commented Mar 21, 2019

@aheissenberger on top updating the packages, if you look at the commit, I am using a new feature of the emulator.

@aheissenberger
Copy link
Owner

@bboure sorry - I missed the change - 1.3.1 add this change

@bboure
Copy link
Author

bboure commented Mar 21, 2019

great thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants