Adds 404 error if page not found

aheenam · Nov 2, 2017 · bbbd789 · bbbd789
1 parent d4cadb8
commit bbbd789
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Controllers/FrontendController.php b/src/Controllers/FrontendController.php
@@ -4,6 +4,7 @@
 use Aheenam\Mozhi\RouteResolver;
 use Aheenam\Mozhi\TemplateRenderer;
 use Illuminate\Routing\Controller;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class FrontendController extends Controller
 {
@@ -16,6 +17,8 @@ public function show($slug)
     {
         $page = (new RouteResolver)->getPageByRoute($slug);
 
+        if ($page === null) throw new NotFoundHttpException();
+
         $view = (new TemplateRenderer($page))->render([]);
 
         return response($view, 200);

diff --git a/tests/FrontControllerTest.php b/tests/FrontControllerTest.php
@@ -15,4 +15,12 @@ public function it_renders_correct_view_on_route()
 
         $this->assertMatchesSnapshot($response->getContent());
     }
+
+    /** @test */
+    public function it_returns_a_404_if_route_not_found()
+    {
+        $this->get('/not-found')
+            ->assertStatus(404);
+    }
+
 }