Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original code has some mistake. so it is better to change code
li = open(path, 'w')
->
lines = open(path, 'r').read().split('\n')
wrong variable and it isnt possible to do function's role
template_start = '{"German":"'
->
template_start = '{"English":"'
wrong comment
english_file = process_file(german_file)
->
german_file = process_file(german_file)
wrong variable
with open(path, 'r') as f:
for file in file_list:
f.write('\n')
->
with open(path, 'w') as f:
for file in file_list:
f.write(file + '\n')
wrong purpose to open and ommsion of file to writing
german_file_list = train_file_list_to_json(german_path)
processed_file_list = path_to_file_list(english_file_list, german_file_list)
->
german_file_list = path_to_file_list(german_path)
processed_file_list = trin_file_list_to_json(english_file_list, german_file_list)
wrong uses of functions