Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed main.py #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed main.py #216

wants to merge 1 commit into from

Conversation

EuiseongHong
Copy link

Modifications Made:
line 5:
li = open(path, 'w') --> lines = open(path, 'r').read().split('\n')
This change was made to ensure that the file is opened with read option and each line was added in as a element in each list.
The previous code did not return anything because we did not initialize any value in lines. Also it opened the file with w option even though we needed to read the lines off the file with the r option
line 14:
file = file.replace('\', '\') --> file = file.replace('\', '\\')
This change was made so that \ will be replaced with \\ not \ itself like the previous code.
The previous code was wrong because it was replacing // with // which does not make any difference.
line 37-39:
with open(path, 'r') as f:
for file in file_list:
f.write('\n')

-->

with open(path, 'w') as f:
for file in file_list:
f.write(file + '\n')
This change was made so that we open the file with w option and also write the strings with \n.
The previous code opened the file with r option, which cannot write in the file. Also it did not write the strings as intended.

These are the modifications I made. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants