Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Linter Yell At Us: Create lint.yml - testing lint options #26

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
on: [pull_request]

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: grantmcconnaughey/[email protected]
with:
# The GitHub API token to create reviews with
token: ${{ secrets.GITHUB_TOKEN }}
# Fail if "new" violations detected or "any", default "new"
failIf: any
# Additional arguments to pass to flake8, default "." (current directory)
args: "--ignore=E121,E123 ."
3 changes: 2 additions & 1 deletion agu_oss/clean_data.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""A second sample module to clean data."""

import pandas as pd
import numpy as np

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401: 'numpy as np' imported but unused


def open_and_clean(url):
"""
Expand All @@ -20,7 +21,7 @@ def open_and_clean(url):
"""

temp_df = pd.read_csv(url,
skiprows=69,
skiprows = 69,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E251: unexpected spaces around keyword / parameter equals

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E251: unexpected spaces around keyword / parameter equals

delim_whitespace=True)

all_cols = temp_df.columns[1:]
Expand Down