Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project] update dependencies to allow proper build #219

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Dec 12, 2024

Fix for implementing https://github.com/agritheory/fab/issues/55.

Currently, there seems to be a bug while trying to import and use the ATable component using the pinia store. Here's a reproduction for it.

This PR isn't completely ready since builds are failing for Stonecrop, but it also simplifies some parts of the build process and fleshes out the auto-documenter.

@Alchez Alchez added the bug Something isn't working label Dec 12, 2024
@Alchez Alchez changed the title [WIP] [project] update dependencies to allow proper build [project] update dependencies to allow proper build Dec 12, 2024
@Alchez Alchez requested a review from agritheory December 12, 2024 12:26
@Alchez Alchez marked this pull request as ready for review December 13, 2024 06:38
@Alchez Alchez force-pushed the fix-stonecrop-dist-update branch from 69261cd to 8034450 Compare December 13, 2024 06:42
Copy link
Contributor

Coverage Report for ./beam

Status Category Percentage Covered / Total
🔴 Lines 5.3% (🎯 70%) 7 / 132
🔴 Statements 5.59% (🎯 70%) 8 / 143
🔴 Functions 2.43% (🎯 70%) 1 / 41
🔴 Branches 0% (🎯 70%) 0 / 81
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
beam/src/composables/mqtt.ts 0% 0% 0% 0% 12-44
Unchanged Files
beam/src/components/ActionFooter.vue 0% 100% 0% 0% 12-5
beam/src/components/BeamArrow.vue 0% 0% 100% 0% 2-4
beam/src/components/BeamDayDivider.vue 0% 0% 0% 0% 17-2
beam/src/components/BeamFilter.vue 0% 0% 0% 0% 18-9
beam/src/components/BeamFilterOption.vue 0% 0% 0% 0% 41-21
beam/src/components/BeamMetadata.vue 0% 0% 0% 0% 2-1
beam/src/components/BeamModal.vue 0% 0% 0% 0% 3-5
beam/src/components/BeamModalOutlet.vue 0% 100% 100% 0% 2
beam/src/components/BeamProgress.vue 0% 0% 0% 0% 22-3
beam/src/components/Confirm.vue 0% 0% 0% 0% 4-1
beam/src/components/ItemCheck.vue 0% 0% 0% 0% 9-3
beam/src/components/ItemCount.vue 0% 0% 0% 0% 20-1
beam/src/components/ListAnchor.vue 0% 100% 100% 0% 1
beam/src/components/ListItem.vue 0% 0% 0% 0% 27-15
beam/src/components/ListView.vue 0% 0% 0% 0% 29-2
beam/src/components/Navbar.vue 0% 0% 0% 0% 13-null
beam/src/components/ScanInput.vue 88.88% 100% 50% 87.5% 23
beam/src/components/SplitColumn.vue 0% 0% 100% 0% 5-8
Generated in workflow #476 for commit 8034450 by the Vitest Coverage Report Action

Copy link
Contributor

Coverage Report for ./aform

Status Category Percentage Covered / Total
🟢 Lines 86.58% (🎯 70%) 200 / 231
🟢 Statements 86.01% (🎯 70%) 203 / 236
🟢 Functions 80.76% (🎯 70%) 42 / 52
🔴 Branches 67.88% (🎯 70%) 74 / 109
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Unchanged Files
aform/src/components/AForm.vue 90% 40% 85.71% 90% 40-41
aform/src/components/base/CollapseButton.vue 100% 100% 100% 100%
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/AComboBox.vue 0% 0% 100% 0% 2-1
aform/src/components/form/ADate.vue 85.71% 50% 100% 85.71% 38
aform/src/components/form/ADatePicker.vue 94.91% 81.81% 92.85% 94.73% 66, 101, 28
aform/src/components/form/ADropdown.vue 91.48% 76.92% 84.61% 91.48% 55, 84-85, 93
aform/src/components/form/AFieldset.vue 87.5% 100% 50% 87.5% 8
aform/src/components/form/AFileAttach.vue 0% 0% 0% 0% 26-17
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
aform/src/components/form/ATextInput.vue 100% 100% 100% 100%
aform/src/components/utilities/Login.vue 87.5% 88.88% 100% 87.5% 76-78
aform/src/directives/mask.ts 84.09% 59.09% 100% 83.72% 33-34, 41, 50, 65, 98, 103
Generated in workflow #476 for commit 8034450 by the Vitest Coverage Report Action

@Alchez Alchez merged commit ba8db74 into development Dec 13, 2024
4 of 7 checks passed
@Alchez Alchez deleted the fix-stonecrop-dist-update branch December 13, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant