Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atable] Fix atable gray border #201

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Conversation

crabinak
Copy link
Collaborator

@crabinak crabinak commented Dec 2, 2024

This adds a gray left border to Atable. I added this to the first cell of each row so that it doesn't cause issues with pinned column sizing. It works with both indexed and non-indexed rows since it just grabs the first td in the row.

I also added a variable --sc-cell-changed-color that uses the light blue color for cell changes. There was a stray background:yellow override in the default histoire file that I removed.

Finally, vertical padding is reduced on rows.

@crabinak crabinak requested a review from agritheory December 2, 2024 19:18
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Coverage Report for ./atable

Status Category Percentage Covered / Total
🟢 Lines 70.56% (🎯 70%) 151 / 214
🟢 Statements 71.11% (🎯 70%) 160 / 225
🟢 Functions 80.95% (🎯 70%) 34 / 42
🔴 Branches 50% (🎯 70%) 87 / 174
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
atable/src/components/ACell.vue 93.87% 61.11% 100% 93.87% 100, 123-126, 157
atable/src/components/AExpansionRow.vue 0% 0% 0% 0% 33-3
atable/src/components/ARow.vue 58.33% 56.25% 50% 58.33% 50-64, 17
atable/src/components/ATable.vue 55.1% 37.5% 88.88% 54.16% 107-111, 117-145
Unchanged Files
atable/src/utils.ts 100% 100% 100% 100%
atable/src/components/ATableHeader.vue 100% 57.14% 100% 100%
atable/src/components/ATableModal.vue 50% 100% 0% 50% 26
atable/src/stores/table.ts 77.65% 54.54% 88.88% 77.64% 33-34, 47, 77-78, 116, 120-131, 158, 166-167, 173
Generated in workflow #470 for commit 9b3c2bc by the Vitest Coverage Report Action

@agritheory
Copy link
Owner

@crabinak This color between the aform and atable left borders seems to be inconsistent. And I'm not sure that the expanded row in the expansion table shouldn't have a left border.
image

@crabinak
Copy link
Collaborator Author

crabinak commented Dec 3, 2024

@agritheory I updated the gray to match the aform border. One issue that arises is there are now two types of gray borders on atable: the table row dividers which are darker gray and the lighter gray of the left-hand border.

atable-borders

I can think of two solutions:

  1. Update the color of atable row dividers to match the light gray aform border color.

atable-border-light

  1. Update aform borders to match the darker gray of the atable row dividers.

atable-border-dark

I'd probably be leaning towards using the darker gray for aform to match atable since the fields of aform are already darker, but let me know what you think.

@crabinak
Copy link
Collaborator Author

@agritheory The atable now uses dark gray for its borders. I have a half size border for the expanded row (2px vs. 4px). I also updated aform's border color to match the atable border.

@agritheory agritheory changed the title Fix atable gray border [atable] Fix atable gray border Dec 13, 2024
@agritheory agritheory merged commit c777f22 into development Dec 13, 2024
4 of 5 checks passed
@Alchez Alchez deleted the fix-atable-gray-border branch December 17, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants