-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[atable] Fix atable gray border #201
Conversation
Coverage Report for ./atable
File Coverage
|
@crabinak This color between the aform and atable left borders seems to be inconsistent. And I'm not sure that the expanded row in the expansion table shouldn't have a left border. |
@agritheory I updated the gray to match the aform border. One issue that arises is there are now two types of gray borders on atable: the table row dividers which are darker gray and the lighter gray of the left-hand border. I can think of two solutions:
I'd probably be leaning towards using the darker gray for aform to match atable since the fields of aform are already darker, but let me know what you think. |
…y/stonecrop into fix-atable-gray-border
@agritheory The atable now uses dark gray for its borders. I have a half size border for the expanded row (2px vs. 4px). I also updated aform's border color to match the atable border. |
This adds a gray left border to Atable. I added this to the first cell of each row so that it doesn't cause issues with pinned column sizing. It works with both indexed and non-indexed rows since it just grabs the first td in the row.
I also added a variable
--sc-cell-changed-color
that uses the light blue color for cell changes. There was a straybackground:yellow
override in the default histoire file that I removed.Finally, vertical padding is reduced on rows.