Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beam] add list filter component #179

Merged
merged 13 commits into from
Nov 7, 2024
Merged

Conversation

crabinak
Copy link
Collaborator

@crabinak crabinak commented Nov 4, 2024

@agritheory
Here is a Filter component put together for the Beam ListView #175 . I added a FixedTop wrapper component for the NavBar and Filter to sit in to stick them both to the top without having to worry about height management.

I set up the BeamFilter component to use BeamFilterOption sub components where key:value pairs can be passed in as props for each selection option. This component can basically be duplicated for each filter option you want. I opted to not use the HTML select element here as there is very little control over the styling of options.

I tried to make the menus slightly larger to accommodate a user navigating with a finger on a mobile device.

@crabinak crabinak requested review from Alchez and agritheory November 4, 2024 15:57
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Coverage Report for ./beam

Status Category Percentage Covered / Total
🔴 Lines 5.88% (🎯 70%) 7 / 119
🔴 Statements 6.4% (🎯 70%) 8 / 125
🔴 Functions 2.77% (🎯 70%) 1 / 36
🔴 Branches 0% (🎯 70%) 0 / 68
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
beam/src/components/BeamArrow.vue 0% 0% 100% 0% 2-4
beam/src/components/BeamFilter.vue 0% 0% 0% 0% 18-9
beam/src/components/BeamFilterOption.vue 0% 0% 0% 0% 41-21
beam/src/components/BeamProgress.vue 0% 0% 0% 0% 22-3
beam/src/components/SplitColumn.vue 0% 0% 100% 0% 5-8
Unchanged Files
beam/src/components/ActionFooter.vue 0% 100% 0% 0% 12-3
beam/src/components/BeamMetadata.vue 0% 0% 0% 0% 2-1
beam/src/components/BeamModal.vue 0% 0% 0% 0% 3-5
beam/src/components/BeamModalOutlet.vue 0% 100% 100% 0% 2
beam/src/components/Confirm.vue 0% 0% 0% 0% 4-5
beam/src/components/ItemCheck.vue 0% 0% 0% 0% 9-3
beam/src/components/ItemCount.vue 0% 0% 0% 0% 18-1
beam/src/components/ListAnchor.vue 0% 100% 100% 0% 1
beam/src/components/ListItem.vue 0% 0% 0% 0% 37-14
beam/src/components/ListView.vue 0% 0% 0% 0% 36-null
beam/src/components/Navbar.vue 0% 0% 0% 0% 13-null
beam/src/components/ScanInput.vue 88.88% 100% 50% 87.5% 23
beam/src/composables/mqtt.ts 0% 0% 0% 0% 8-40
Generated in workflow #412 for commit 5bb0fc8 by the Vitest Coverage Report Action

beam/src/components/BeamFilter.vue Outdated Show resolved Hide resolved
beam/src/components/BeamFilterOption.vue Outdated Show resolved Hide resolved
beam/src/components/BeamFilterOption.vue Outdated Show resolved Hide resolved
beam/src/components/ToggleArrow.vue Outdated Show resolved Hide resolved
@Alchez Alchez linked an issue Nov 5, 2024 that may be closed by this pull request
@crabinak
Copy link
Collaborator Author

crabinak commented Nov 5, 2024

@Alchez Thanks. I committed those changes to the branch.

@Alchez Alchez changed the title Feat beam list filter style feat: beam list filter style Nov 6, 2024
@Alchez Alchez changed the title feat: beam list filter style [beam] add list filter component Nov 6, 2024
@Alchez Alchez marked this pull request as ready for review November 7, 2024 07:34
@Alchez Alchez merged commit 15353c6 into development Nov 7, 2024
4 checks passed
@Alchez Alchez deleted the feat-beam-list-filter-style branch November 7, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mobile] Scanning API fixes
3 participants