-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beam] add list filter component #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alchez
requested changes
Nov 5, 2024
common/changes/@stonecrop/beam/feat-beam-list-filter-style_2024-11-04-03-12.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Rohan <[email protected]>
Co-authored-by: Rohan <[email protected]>
…4-11-04-03-12.json Co-authored-by: Rohan <[email protected]>
@Alchez Thanks. I committed those changes to the branch. |
Alchez
approved these changes
Nov 6, 2024
agritheory
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agritheory
Here is a Filter component put together for the Beam ListView #175 . I added a FixedTop wrapper component for the NavBar and Filter to sit in to stick them both to the top without having to worry about height management.
I set up the BeamFilter component to use BeamFilterOption sub components where key:value pairs can be passed in as props for each selection option. This component can basically be duplicated for each filter option you want. I opted to not use the HTML select element here as there is very little control over the styling of options.
I tried to make the menus slightly larger to accommodate a user navigating with a finger on a mobile device.