Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project] include dist folder during NPM publishing #125

Merged
merged 1 commit into from
May 2, 2024

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented May 2, 2024

This should potentially fix the issues we're seeing with CI builds, as noted here, as well as setting up working environments as noted here.

Context:
We ignored the dist folders in the .gitignore file in #116, but NPM actually uses that as a fallback measure to decide what should show up in the packaged files in NPM. Since our entrypoints rely on the dist folder existing, new installs of our packages fail.

Solution:
I added an .npmignore file to apply most of the rules/patterns in our .gitignore file, but allow publishing the dist folder as well. This way, our development can still avoid build files and our packages can ship with the distributables.

Test:
If you install @stonecrop/atable in a new project and try to import anything from it, it'll fail trying to resolve the object. I tested the .npmignore on my fork of Stonecrop and I was able to install and import objects without an issue.

@Alchez Alchez requested a review from agritheory May 2, 2024 10:45
@agritheory agritheory merged commit 7471655 into development May 2, 2024
6 checks passed
@Alchez Alchez deleted the fix-missing-dist-npm branch May 2, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants