[project] include dist folder during NPM publishing #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should potentially fix the issues we're seeing with CI builds, as noted here, as well as setting up working environments as noted here.
Context:
We ignored the
dist
folders in the.gitignore
file in #116, but NPM actually uses that as a fallback measure to decide what should show up in the packaged files in NPM. Since our entrypoints rely on thedist
folder existing, new installs of our packages fail.Solution:
I added an
.npmignore
file to apply most of the rules/patterns in our.gitignore
file, but allow publishing thedist
folder as well. This way, our development can still avoid build files and our packages can ship with the distributables.Test:
If you install
@stonecrop/atable
in a new project and try to import anything from it, it'll fail trying to resolve the object. I tested the.npmignore
on my fork of Stonecrop and I was able to install and import objects without an issue.