Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aform] add login utility component #113

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Apr 18, 2024

Closes #110.


ToDo:

  • Confirm styling generally matches the default theme
  • Create a login example story

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Coverage Report for ./aform

Status Category Percentage Covered / Total
🔴 Lines 50.16% (🎯 70%) 599 / 1194
🔴 Statements 50.16% (🎯 70%) 599 / 1194
🔴 Functions 51.28% (🎯 70%) 20 / 39
🔴 Branches 65.95% (🎯 70%) 31 / 47
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
aform/src/components/utilities/Login.vue 0% 0% 0% 0% 1-72
Unchanged Files
aform/src/index.ts 0% 0% 0% 0% 1-27
aform/src/components/AForm.vue 92.3% 80% 83.33% 92.3% 41-44, 65-66
aform/src/components/base/CollapseButton.vue 0% 0% 0% 0% 1-36
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/AComboBox.vue 0% 0% 0% 0% 1-13
aform/src/components/form/ADate.vue 0% 0% 0% 0% 1-277
aform/src/components/form/ADropdown.vue 85.43% 89.47% 50% 85.43% 68-70, 77-78, 92-93, 99-103, 108-109, 114-117, 119-122, 124-127, 129-132
aform/src/components/form/AFieldset.vue 0% 0% 0% 0% 1-63
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
aform/src/components/form/ATextInput.vue 100% 80% 100% 100%
aform/src/directives/mask.ts 31.73% 28.57% 40% 31.73% 13-22, 28-34, 40-41, 47-60, 62-78, 83-103
Generated in workflow #147

@Alchez Alchez requested review from agritheory and crabinak April 19, 2024 08:47
@Alchez
Copy link
Collaborator Author

Alchez commented Apr 19, 2024

@agritheory @crabinak I've added a login component that's similar to the shadcn-vue template (but it's made for login rather than creating an account).

I've setup some basic styling based on the Tailwind classes setup in their template, but I think someone else should handle the stylesheets here 😅

@crabinak
Copy link
Collaborator

@Alchez I can handle the stylesheet on this.

@Alchez
Copy link
Collaborator Author

Alchez commented Apr 19, 2024

@Alchez I can handle the stylesheet on this.

Thank you!

@Alchez
Copy link
Collaborator Author

Alchez commented Apr 22, 2024

@crabinak @agritheory I've created a merge commit that removes the dist folders from the diff, so the changes should be easier to read now.

Repository owner deleted a comment from github-actions bot Apr 22, 2024
@crabinak
Copy link
Collaborator

@Alchez @agritheory I have added styling to this login. I'm importing styles from the default.css file to avoid duplication and maintain consistency, but let me know if this violates the monorepo design pattern at all.

I've also setup an animated loading icon to appear when the user clicks the login button and bound it to isLoading. This uses Google Material Icons, but let me know if a different icon library is preferred.

@agritheory agritheory marked this pull request as ready for review April 22, 2024 17:25
Copy link
Owner

@agritheory agritheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. @crabinak Loading animation is very nice. I think we might explore some more custom work there soon.

@agritheory agritheory merged commit 34e6024 into development Apr 22, 2024
5 of 6 checks passed
@agritheory agritheory deleted the feat-login-util branch April 22, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aform] Login component and example
3 participants