Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stonecrop] publish packages to NPM #105

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Apr 16, 2024

Closes #100.


Additional notes:

  • I tested it locally, and I was able to publish the packages to my personal account.
  • Since the package namespace has changed and they aren't published on NPM yet, they won't be available for local install. Until they're published, a local test would require managing dependencies across the project using yarn link (to register a package locally) and yarn link <project_name> (to use the registered package locally).
  • If you're testing this locally, you would need to setup an access token in your NPM account (https://www.npmjs.com/settings/USER/tokens) and export it in your local env as a variable called NODE_AUTH_TOKEN.
  • For production releases, we would need to add an NPM_TOKEN secret in this repo's action secrets. Since we used to use Github's package registry, this was automatically available as an env variable.

@Alchez Alchez requested a review from agritheory April 16, 2024 06:43
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Coverage Summary for `./atable`

Status Category Percentage Covered / Total
🟢 Lines 67.54% / 10% 591 / 875
🟢 Statements 67.54% / 10% 591 / 875
🟢 Functions 54.16% / 10% 13 / 24
🟢 Branches 46.29% / 10% 25 / 54
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
atable/src/index.ts 0% 0% 0% 0% 1-20
atable/src/components/ACell.vue 82.62% 38.09% 75% 82.62% 19-21, 59-65, 74-76, 79-81, 84-94, 110-114, 144-147, 165
atable/src/components/AExpansionRow.vue 0% 0% 0% 0% 1-88
atable/src/components/ARow.vue 65.51% 20% 25% 65.51% 6-12, 46-67, 72-73, 78-79, 82-88
atable/src/components/ATable.vue 65.71% 50% 25% 65.71% 101-140, 143-146, 149-155, 159-179
atable/src/components/ATableHeader.vue 98.33% 28.57% 100% 98.33% 1
atable/src/components/ATableModal.vue 96% 100% 0% 96% 21-22
atable/src/components/index.ts 79.66% 84.61% 87.5% 79.66% 47-54, 61-62, 104-117

Copy link
Owner

@agritheory agritheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added the secret to the repo.

@agritheory agritheory merged commit 70e791c into development Apr 16, 2024
6 checks passed
@Alchez Alchez deleted the fix-publish-npm branch April 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish to NPM
2 participants