Grant file download access for multiple downloads to specific roles. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agritheory
requested changes
Apr 29, 2024
| @@ -399,6 +410,9 @@ function download_nacha(frm) { | |||
| window.setTimeout(() => { | |||
| frm.reload_doc() | |||
| }, 1000) | |||
| if (!frm.doc.ach_file_generated) { | |||
| frappe.db.set_value('Check Run', frm.doc.name, 'ach_file_generated', 1) | |||
There was a problem hiding this comment.
Please refactor this to use a whitelisted function. Generally we want to avoid the use of the frappe.db API in JS because of the permissions issues it presents.
|
@agritheory I am closing this PR and open a new one for V15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#216