chore: use decimal places with token values on the home page #74
Conversation
Deploying agoric-inter-dashboard with
|
| Latest commit: |
90369ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4494ec7a.agoric-inter-dashboard.pages.dev |
| Branch Preview URL: | https://rs-decimal-places-homepage.agoric-inter-dashboard.pages.dev |
|
Cloudflare deployment logs are available here |
rabi-siddique
force-pushed
the
rs-decimal-places-homepage
branch
from
698ca68 to
bf27078
Compare
rabi-siddique
changed the title
| ((Number(node_?.value) / tokenDivisor) * Number(oraclePrices[node_?.denom]?.typeOutAmount || tokenDivisor)) / | ||
| tokenDivisor; |
There was a problem hiding this comment.
| ((Number(node_?.value) / tokenDivisor) * Number(oraclePrices[node_?.denom]?.typeOutAmount || tokenDivisor)) / | |
| tokenDivisor; | |
| ((Number(node_?.value) / tokenDivisor) * Number(oraclePrices[node_?.denom]?.typeOutAmount || 0)) / | |
| Number(oraclePrices[node_?.denom]?.typeInAmount; |
There was a problem hiding this comment.
This results in incorrect value for Total Reserve Assets
There was a problem hiding this comment.
we should probably use Number(oraclePrices[node_?.denom]?.typeInAmount instead of the deafault of 0 then
There was a problem hiding this comment.
we should probably use Number(oraclePrices[node_?.denom]?.typeInAmount
I reckon you are implying typeOutAmount?
There was a problem hiding this comment.
no typeInAmount
the goal is to divide typeInAmount by typeInAmount to create a value of 1
There was a problem hiding this comment.
but i think if typeOutAmount is not present, then typeInAmount wont also be present. lets do this instead:
Number(oraclePrices[node_?.denom]?.typeOutAmount || 1)) /
Number(oraclePrices[node_?.denom]?.typeInAmount || 1);
| dashboardResponse.reserveMetrics.nodes.reduce((agg, node) => agg + Number(node.shortfallBalance), 0) / 1_000_000; | ||
| const totalLockedCollateral = dashboardResponse.vaultManagerMetrics.nodes.reduce((agg, node) => { | ||
| dashboardResponse?.reserveMetrics?.nodes?.reduce((agg, node) => agg + Number(node?.shortfallBalance), 0) / | ||
| istTokenDivisor; |
There was a problem hiding this comment.
probably shouldnt be divided by the istTokenDivisor but rather the token divisior of each node
There was a problem hiding this comment.
Are you sure? It results in different values compared to production
There was a problem hiding this comment.
not 100%. my logic is that this value represent reserve data. when we calculate totalReserve above, which also represents reserve data, we also use token divisor rather than ist divisor
There was a problem hiding this comment.
I am confused too:
There was a problem hiding this comment.
i guess then istdivisor is fine
rabi-siddique
force-pushed
the
rs-decimal-places-homepage
branch
from
7c7fbf1 to
37e1e57
Compare
src/pages/InterProtocol.tsx
Outdated
| Number(oraclePrices[node.liquidatingCollateralBrand]?.typeOutAmount) || 0) / 1_000_000; | ||
| ((Number(node?.totalCollateral) / tokenDivisor) * | ||
| Number(oraclePrices[node?.liquidatingCollateralBrand]?.typeOutAmount) || 0) / | ||
| Number(oraclePrices[node?.liquidatingCollateralBrand]?.typeInAmount || 0); |
There was a problem hiding this comment.
dont use default value here. 0 will result in a divide by zero error
There was a problem hiding this comment.
Wouldn't that be fine? 0/0 will be NaN..........would be easier to point anomalies from the dashboard UI.
If we omit the 0 default, it will still be a NaN(0/undefined and undefined/undefined)
There was a problem hiding this comment.
Removing the defaults. It's going to yield a NaN regardless.
There was a problem hiding this comment.
true. i thought it might throw an Error.
rabi-siddique
force-pushed
the
rs-decimal-places-homepage
branch
from
37e1e57 to
f42d015
Compare
rabi-siddique
force-pushed
the
rs-decimal-places-homepage
branch
from
6380e0f to
81b1a32
Compare
No description provided.