Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env: npm audit fix some devDeps #72

Merged
merged 1 commit into from
Feb 19, 2022
Merged

env: npm audit fix some devDeps #72

merged 1 commit into from
Feb 19, 2022

Conversation

agilgur5
Copy link
Owner

Description

  • auto update a few hundred vulns in the devDeps

    • they are just devDeps, so no impact on prod
  • rest is limited by the years old build system, which will be updated
    soon to something at least less old

Review Notes

Another small stop-gap before #42 is merged (which is also dated now)

- auto update a few hundred vulns in the devDeps
  - they are just devDeps, so no impact on prod

- rest is limited by the years old build system, which will be updated
  soon to something at least less old
@agilgur5 agilgur5 added kind: internal Changes only affect the internals and not the API or usage scope: dependencies Pull requests that update a dependency file labels Feb 19, 2022
Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests pass, builds still work, example still works

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #72 (3af525a) into main (206eea1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           59        59           
  Branches         6         6           
=========================================
  Hits            59        59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206eea1...3af525a. Read the comment docs.

@agilgur5 agilgur5 merged commit 2bee129 into main Feb 19, 2022
@agilgur5 agilgur5 deleted the env-audit-fix-devDeps branch February 19, 2022 22:16
@agilgur5
Copy link
Owner Author

36 dependabot alerts got auto-closed 👍

Repository owner locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind: internal Changes only affect the internals and not the API or usage scope: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant