Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade react-hot-loader for example to work with latest React #71

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

agilgur5
Copy link
Owner

Description

Review Notes

This is more of a stop-gap until #42 is merged, which switches the example to use Parcel etc (and updates all devDeps)

- was getting a difficult-to-interpret error when running `npm start`
  - https://stackoverflow.com/q/40652327/3431180
  - fixed by upgrading react-hot-loader and updating the config
    accordingly
@agilgur5 agilgur5 added scope: example An example or examples could be improved kind: internal Changes only affect the internals and not the API or usage scope: dependencies Pull requests that update a dependency file labels Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #71 (71019a8) into main (2781869) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           59        59           
  Branches         6         6           
=========================================
  Hits            59        59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2781869...71019a8. Read the comment docs.

Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. small change. made sure that the prod build wasn't affected/changed by this (though #42 will likely be merged before the next release anyway)

@agilgur5 agilgur5 merged commit 206eea1 into main Feb 19, 2022
@agilgur5 agilgur5 deleted the fix-example-react-hot-loader branch February 19, 2022 21:34
Repository owner locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind: internal Changes only affect the internals and not the API or usage scope: dependencies Pull requests that update a dependency file scope: example An example or examples could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant