Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted package management system workflow to pipenv. #568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathanmeier5
Copy link

Awesome project! Was just thinking of building something similar and stumbled across this repo.

I'm opening this PR to start a discussion about moving this template onto Pipenv. It's a great python workflow tool developed by the same people who wrote the requests library. If you're interested, have a look at their docs: http://pipenv.readthedocs.io/en/latest/.

It seems like you guys are interested in staying on the cutting edge of tooling, so I thought you might be interested.

@agconti agconti self-assigned this Feb 25, 2018
@agconti
Copy link
Owner

agconti commented Feb 25, 2018

@jonathanmeier5 Thanks for opening this PR! 🔥 🎉

I'm pretty exited about pipenv but haven't had a chance to dig into it. This is definitely something I'd like to add to the project. Let me do a deeper dive into it and I'll get back to you!

@agconti agconti mentioned this pull request Feb 25, 2018
2 tasks
@agconti
Copy link
Owner

agconti commented Mar 12, 2018

@jonathanmeier5 I finished digging into pipenv and I'm ready to merge this PR.
Thanks for doing an awesome job converting this project to use it!! ✨💥

Whats your thoughts around adding the deploy flag to install statement? The benefit being that a build will fail if the Pipfile.lock is out–of–date.

pipenv install --system --deploy

@agconti
Copy link
Owner

agconti commented May 31, 2018

Holding off on this since its not well supported by pyup.io. That tool is critical to keep the project on the up-to-date. I'll merge once they provide more robust support.

@lingster
Copy link

you can run the command: pipenv lock --requirements and this will generate an updated requirements.txt based off of the pipfile. This would help maintain compatiability...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants