Update controller property for Oculus Quest #4567
Conversation
|
what do you mean by wrong? |
|
It seems that the controller's ray direction adjusted for earlier version of the OculusBrowser. (It actually worked correctly). However, there is now a difference from the direction of the ray on the home screen. ray in Home: A-Frame 1.0.4: |
|
We should probably use |
| rayOrigin: {origin: {x: -0.01, y: 0, z: -0.02}, direction: {x: 0, y: -0.5, z: -1}}, | ||
| modelPivotOffset: new THREE.Vector3(0, 0, 0), | ||
| rayOrigin: {origin: {x: 0, y: 0, z: 0}, direction: {x: 0, y: 0, z: -1}}, | ||
| modelPivotOffset: new THREE.Vector3(0.01, 0.005, 0.03), |
There was a problem hiding this comment.
Why does the model position need to be adjusted? I thought the problem was only with the ray position.
There was a problem hiding this comment.
It seems that the model is slightly out of position. I adjusted the offset so that the model position does not change when entering/leaving VR.
However it is only tested on my Oculus Quest, so I'll also consider to reset the change.
There was a problem hiding this comment.
Better to separate changes and put the model shift in a different PR if necessary. I still think that for the rayOrigin we should probably use InputSource values instead of hard coding numbers.
There was a problem hiding this comment.
Sorry for late, I reverted the change for model shift.
Also, it seems that XRInputSource.targetRaySpace has already been applied to the pose of controllers. https://github.com/aframevr/aframe/blob/master/src/components/tracked-controls-webxr.js#L115 So rayOrigin and direction may not be needed if XRInputSource is available.
|
As mentioned, we should be using |
Description:
The ray direction of oculus quest controller in the WebXR session is wrong. So adjusted direction and position.
The direction within WebVR API may will be broken, but the latest Oculus Browser no longer supports the WebVR.
Changes proposed: