FIX: Parsing nodes with no name

This was previously failing with: `NoMethodError: undefined method `downcase' for nil:NilClass`
affinity · Sep 22, 2020 · a6d7569 · a6d7569
1 parent c883f6c
commit a6d7569
Show file tree

Hide file tree

Showing 3 changed files with 62 additions and 5 deletions.
diff --git a/lib/html2text.rb b/lib/html2text.rb
@@ -99,16 +99,20 @@ def iterate_over(node)
 
     output << prefix_whitespace(node)
     output += node.children.map do |child|
-      iterate_over(child)
+      if !child.name.nil?
+        iterate_over(child)
+      end
     end
     output << suffix_whitespace(node)
 
     output = output.compact.join("") || ""
 
-    if node.name.downcase == "a"
-      output = wrap_link(node, output)
-    elsif node.name.downcase == "img"
-      output = image_text(node)
+    if !node.name.nil?
+      if node.name.downcase == "a"
+        output = wrap_link(node, output)
+      elsif node.name.downcase == "img"
+        output = image_text(node)
+      end
     end
 
     return output

diff --git a/spec/examples/malformed-style.html b/spec/examples/malformed-style.html
@@ -0,0 +1,52 @@
+<html>
+<head>
+  <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+  <title>title</title>
+</head>
+<body>
+<!DOCTYPE >
+<style type="text/css">
+  body,
+  p,
+  span,
+  h1,
+  h2,
+  h3,
+  h4,
+  h5,
+  h6,
+  tr,
+  td,
+  a,
+  label,
+  div,
+  button,
+  input,
+  caption,
+  input,
+  textarea,
+  legend,
+  li,
+  ol,
+  select,
+  summary,
+  table,
+  td,
+  tbody,
+  th,
+  thead,
+  ul {
+    font-family: Arial !important;
+  }</style
+><!--[if mso
+      ]><style type="text/css">
+        body,
+        table,
+        td {
+          font-family: Arial, Helvetica, sans-serif !important;
+        }
+      </style><!
+    [endif]-->
+<p>Some body</p>
+</body>
+</html>
diff --git a/spec/examples/malformed-style.txt b/spec/examples/malformed-style.txt
@@ -0,0 +1 @@
+Some body