fix: Account for viewport position in sprite backend #365

johanhelsing · 2024-09-04T06:25:32Z

Fixes #364

#16386) # Objective - When picking sprites, the pointer is offset from the mouse, causing you to pick sprites you're not mousing over! ## Solution - Shift over the cursor by the minimum of the viewport. ## Testing - I was already using the bevy_mod_picking PR for my project, so it seems to work! - I tested this on the sprite_example (making the camera only render to part of the viewport), and it also works there. ## Notes - This is just aevyrie/bevy_mod_picking#365 but in Bevy form. - We don't need to renormalize the viewport in any way since the viewport is specified in pixels, so all that matters is that the origin is correct. Co-authored-by: johanhelsing <[email protected]>

andriyDev · 2024-11-14T16:49:49Z

This has been merged into Bevy as bevyengine/bevy#16386

#16386) # Objective - When picking sprites, the pointer is offset from the mouse, causing you to pick sprites you're not mousing over! ## Solution - Shift over the cursor by the minimum of the viewport. ## Testing - I was already using the bevy_mod_picking PR for my project, so it seems to work! - I tested this on the sprite_example (making the camera only render to part of the viewport), and it also works there. ## Notes - This is just aevyrie/bevy_mod_picking#365 but in Bevy form. - We don't need to renormalize the viewport in any way since the viewport is specified in pixels, so all that matters is that the origin is correct. Co-authored-by: johanhelsing <[email protected]>

bevyengine#16386) # Objective - When picking sprites, the pointer is offset from the mouse, causing you to pick sprites you're not mousing over! ## Solution - Shift over the cursor by the minimum of the viewport. ## Testing - I was already using the bevy_mod_picking PR for my project, so it seems to work! - I tested this on the sprite_example (making the camera only render to part of the viewport), and it also works there. ## Notes - This is just aevyrie/bevy_mod_picking#365 but in Bevy form. - We don't need to renormalize the viewport in any way since the viewport is specified in pixels, so all that matters is that the origin is correct. Co-authored-by: johanhelsing <[email protected]>

fix: Account for viewport position in sprite backend

04139be

andriyDev mentioned this pull request Nov 14, 2024

Fix sprite picking backend not considering the viewport of the camera. bevyengine/bevy#16386

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Account for viewport position in sprite backend #365

fix: Account for viewport position in sprite backend #365

johanhelsing commented Sep 4, 2024

andriyDev commented Nov 14, 2024

fix: Account for viewport position in sprite backend #365

Are you sure you want to change the base?

fix: Account for viewport position in sprite backend #365

Conversation

johanhelsing commented Sep 4, 2024

andriyDev commented Nov 14, 2024