Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build bin package #1468

Closed

Conversation

carlsmedstad
Copy link
Contributor

This package has a high probability of conflicting with another package due to the generic name. It is also redundant since the executable now lives in aesara/bin/.

This package has a high probability of conflicting with another package
due to the generic name. It is also redundant since the executable now
lives in aesara/bin/.
@brandonwillard brandonwillard added bug Something isn't working setup and installation Relates to the setup and installation of Aesara labels Mar 11, 2023
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this affect the installation/setup of the aesara-cache command-line tool? That's the only thing I'm aware of in the bin directory.

@maresb
Copy link
Contributor

maresb commented Mar 11, 2023

Thanks for bringing this to our attention. We are already aware, and we are already planning to deprecate this. See #1382.

In short, it's been this way for years without anyone complaining. But since it's a terrible structure, we're already phasing it out. Since the beginning of the year, the bin package has been a pointer to aesara.bin with a deprecation warning, in order to give time to people to fix anything that relies on it.

Given that it's been this way for years without anyone noticing, I'm inclined to think that suddenly removing it is riskier than leaving it in some more months.

Once we decide that enough time has passed (or that it is so offensive that we should delete it immediately), then instead of removing it from the wheel packages, we should delete it entirely. (I've been meaning to prepare a draft PR.)

@carlsmedstad
Copy link
Contributor Author

Got it. Thanks for the quick reply.

I'll patch away the bin package in the AUR package in the meantime.

@maresb
Copy link
Contributor

maresb commented Mar 12, 2023

@carlsmedstad, sounds good, thanks a lot!!!

@maresb
Copy link
Contributor

maresb commented Mar 12, 2023

Closing this in favor of #1469

@maresb maresb closed this Mar 12, 2023
@carlsmedstad carlsmedstad deleted the dont-build-bin-package branch March 12, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working setup and installation Relates to the setup and installation of Aesara
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants