Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staging #46

Merged
merged 10 commits into from
Nov 10, 2023
Merged

Conversation

moritz-meier
Copy link
Collaborator

@moritz-meier moritz-meier commented Sep 22, 2023

Last three commits on staging broke armv7a-none-eabi support and serde support did not work.

todo: add serde support on opentaws::alerts::Alerts<Alert>.

edit:
todo: fix code coverage action

edit:
todo: add std support for tests on armv7a-none-eabi
todo: add armv7a-none-eabi test to actions

@dadada
Copy link
Collaborator

dadada commented Sep 30, 2023

What do you mean serde support did not work? We used serde support successfully in our WASM demonstrator. I'd be interested in trying to fix this, if you can provide more detail.

@moritz-meier
Copy link
Collaborator Author

moritz-meier commented Sep 30, 2023

I get lots of errors regarding serde when building staging with cargo build --target=armv7a-none-eabi --features=use-serde.

Dont really know why. But this 8b9d556 fixed it.

Did the WASM demo used armv7a-none-eabi?

@dadada
Copy link
Collaborator

dadada commented Sep 30, 2023

Did the WASM demo used armv7a-none-eabi?

Yes, it was for a Zynq7000 platform.

@dadada
Copy link
Collaborator

dadada commented Sep 30, 2023

@moritz-meier
Copy link
Collaborator Author

Last known good commit: https://github.com/aeronautical-informatics/openTAWS?branch=staging#f711303dd3abe281963523846e7845021a93fc49

Thats currently staging (f711303).

Seems like the problem occurs when resolver = "1" or no resolver is specified in workspace Cargo.toml. When switching to resolver = "2" it builds successfully. (6d67c75)

cargo 1.72.1 (103a7ff2e 2023-08-15)

@moritz-meier
Copy link
Collaborator Author

Lets merge this.

@moritz-meier moritz-meier marked this pull request as ready for review October 26, 2023 09:48
@moritz-meier
Copy link
Collaborator Author

lets go.

@moritz-meier
Copy link
Collaborator Author

@wucke13 Lets merge this.

@wucke13 wucke13 enabled auto-merge (rebase) November 10, 2023 15:20
@wucke13 wucke13 self-requested a review November 10, 2023 15:20
@wucke13 wucke13 merged commit cb90060 into aeronautical-informatics:staging Nov 10, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants