Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Deprecation in deep clustering module #2380

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

hadifawaz1999
Copy link
Member

Part of #1518
deprecating clustering_algorithm and clustering_params arguments as they were replaced by estimator

@aeon-actions-bot aeon-actions-bot bot added clustering Clustering package maintenance Continuous integration, unit testing & package distribution labels Nov 22, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Nov 22, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@aeon-actions-bot aeon-actions-bot bot added the full examples run Run all examples on a PR label Nov 22, 2024
@TonyBagnall TonyBagnall merged commit ef18e29 into main Nov 22, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the aif/deep-cltr-dep branch November 22, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clustering Clustering package full examples run Run all examples on a PR maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants