Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Rework _HeterogenousMetaEstimator and composable estimators #2242

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Oct 22, 2024

This is a bit big and messy, but a lot of these composable estimators are intertwined with the mixin which is to be expected really. Just went for a tidy of the whole lot.

  • renames _HeterogenousMetaEstimator to _ComposableEstimatorMixin
  • reworks the class, removing a lot of the methods and functions. Centres input validation around two methods, _check_estimators and _convert_estimators
  • the methods for getting and setting params/attributes should work as intended like the base class now
  • remade ClassifierChannelEnsemble to work with the changed mixin.
  • removes the deprecated WeightedEnsembleClassifier class
  • Adds tests to verify that expected results arrays are actually being used

part of #1518

@aeon-actions-bot aeon-actions-bot bot added classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package testing Testing related issue or pull request labels Oct 22, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Oct 22, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$, $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review October 23, 2024 10:07
@aeon-actions-bot aeon-actions-bot bot added the codecov actions Run the codecov action on a PR label Oct 24, 2024
@TonyBagnall
Copy link
Contributor

have you checked coverage on the related classes? It was previously low
image

image

MatthewMiddlehurst and others added 2 commits October 27, 2024 21:15
# Conflicts:
#	aeon/classification/compose/_ensemble.py
#	aeon/testing/expected_results/results_reproduction/classifier_results_reproduction.py
@MatthewMiddlehurst
Copy link
Member Author

cant check currently

@aeon-actions-bot aeon-actions-bot bot removed the codecov actions Run the codecov action on a PR label Oct 29, 2024
@TonyBagnall TonyBagnall merged commit 15d44e1 into main Oct 29, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the mm/meta branch October 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants