-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Rework _HeterogenousMetaEstimator
and composable estimators
#2242
Conversation
Thank you for contributing to
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
# Conflicts: # aeon/classification/compose/_ensemble.py # aeon/testing/expected_results/results_reproduction/classifier_results_reproduction.py
cant check currently |
This is a bit big and messy, but a lot of these composable estimators are intertwined with the mixin which is to be expected really. Just went for a tidy of the whole lot.
_HeterogenousMetaEstimator
to_ComposableEstimatorMixin
_check_estimators
and_convert_estimators
ClassifierChannelEnsemble
to work with the changed mixin.WeightedEnsembleClassifier
classpart of #1518