Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gas to devtools view #505

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

JerwuQu
Copy link
Contributor

@JerwuQu JerwuQu commented Aug 19, 2022

No description provided.

@JerwuQu JerwuQu marked this pull request as ready for review August 19, 2022 20:54
@JerwuQu
Copy link
Contributor Author

JerwuQu commented Oct 25, 2023

I see that there are some conflicts now. @aduros is this PR interesting? If so I could fix them, otherwise I'll close it.

@aduros
Copy link
Owner

aduros commented Nov 15, 2023

Hey, sorry this fell through the cracks. I like the approach you took and think it would make a great opt-in experiment. If you fix the conflicts I'll merge it 🙂 Please also add:

  1. Let's always show the gas section on the developer tools. If --metering was not used, it should tell the user about the --metering option to enable this feature.
  2. Add some more documentation, either on the site, in the devtools, or a more descriptive --metering help description.

Thanks!

@JerwuQu
Copy link
Contributor Author

JerwuQu commented Dec 29, 2023

I resolved the conflicts for now, but it seems like the wasm-metering package itself might be broken for WASM files using newer features. For example, it works on wasm4nia but throws an exception on Mr.Rafael's Sound Test. I suspect this is due to bulk-memory extensions, but I haven't actually checked if that WASM file uses them.

A closer look and the repo is clearly orphaned, so it shouldn't come as a surprise. Either I'd have to fork it and bring it up to date, or we have to put this PR on ice until someone else does so.

EDIT: Changed this PR into a draft until someone forks the project or creates an alternative.

@JerwuQu JerwuQu marked this pull request as draft April 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants