Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing RTB Tests Copied from OpenRTB Repo #49

Merged
merged 27 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
6d4e088
First commit
jonathansligh-nimbus Sep 17, 2024
64d9341
upgrading one at a time.
jonathansligh-nimbus Sep 17, 2024
70c2c55
updating another
jonathansligh-nimbus Sep 17, 2024
dad2d2c
Going to 4.5.0
jonathansligh-nimbus Sep 17, 2024
e699952
4.2.0 from 3.5.0
jonathansligh-nimbus Sep 17, 2024
f10f229
Back to 4.3.1
jonathansligh-nimbus Sep 18, 2024
25e6d93
4.4.2
jonathansligh-nimbus Sep 18, 2024
350e403
Back to square 1
jonathansligh-nimbus Sep 18, 2024
4e74c66
Slowly
jonathansligh-nimbus Sep 18, 2024
2789319
Updated.
jonathansligh-nimbus Sep 18, 2024
b51625b
Update rtbworkflow.yml
jonathansligh-nimbus Sep 18, 2024
1e2bb02
Update rtbworkflow.yml to change .net versions
jonathansligh-nimbus Sep 18, 2024
58fbd21
Upgrade both
jonathansligh-nimbus Sep 18, 2024
666cb20
Merge branch 'fix_rtb_tests' of https://github.com/adsbynimbus/nimbus…
jonathansligh-nimbus Sep 18, 2024
23f7d5a
was looking in net35 folder?
jonathansligh-nimbus Sep 18, 2024
84e6fec
more path issues.
jonathansligh-nimbus Sep 18, 2024
e487170
Changed some more paths.
jonathansligh-nimbus Sep 18, 2024
d7e87a3
Update rtbworkflow.yml
jonathansligh-nimbus Sep 18, 2024
0b00d06
Try these
jonathansligh-nimbus Sep 18, 2024
d7a8dca
Change path.
jonathansligh-nimbus Sep 18, 2024
aaf56c1
paths...
jonathansligh-nimbus Sep 18, 2024
b05daf3
Fixed
jonathansligh-nimbus Sep 18, 2024
b645d80
path?
jonathansligh-nimbus Sep 18, 2024
140adc5
Adding global.json
jonathansligh-nimbus Sep 18, 2024
b2d97d8
4.4.2
jonathansligh-nimbus Sep 18, 2024
7907763
Path again...
jonathansligh-nimbus Sep 18, 2024
23f95b9
Cleaned up
jonathansligh-nimbus Sep 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/rtbworkflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:
- 'com.adsbynimbus.nimbus/Runtime/Plugins/**'
- '.github/workflows/rtbworkflow*'


jobs:
tests:
name: Running CSharp Tests
Expand All @@ -22,7 +21,7 @@ jobs:

- name: Setup dotnet
uses: actions/setup-dotnet@v4

- uses: actions/cache@v4
with:
path: ~/.nuget/packages
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props" Condition="Exists('..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props')" />
<Import Project="..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props" Condition="Exists('..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props')" />
<Import Project="..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props" Condition="Exists('..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props')" />
<Import Project="..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props" Condition="Exists('..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props')" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand Down Expand Up @@ -46,8 +46,8 @@
<Reference Include="System.Core" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
<Reference Include="nunit.framework, Version=3.5.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb">
<HintPath>..\packages\NUnit.3.5.0\lib\net45\nunit.framework.dll</HintPath>
<Reference Include="nunit.framework, Version=3.14.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb">
<HintPath>..\packages\NUnit.3.14.0\lib\net45\nunit.framework.dll</HintPath>
</Reference>
</ItemGroup>
<ItemGroup>
Expand All @@ -68,7 +68,7 @@
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105.The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NUnit3TestAdapter.4.2.1\build\net35\NUnit3TestAdapter.props'))" />
<Error Condition="!Exists('..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\nunit3testadapter.4.4.2\build\net462\NUnit3TestAdapter.props'))" />
<Error Condition="!Exists('..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.props'))" />
<Error Condition="!Exists('..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.CodeCoverage.17.2.0\build\netstandard1.0\Microsoft.CodeCoverage.targets'))" />
<Error Condition="!Exists('..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.NET.Test.Sdk.17.2.0\build\net45\Microsoft.NET.Test.Sdk.props'))" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Microsoft.CodeCoverage" version="17.2.0" targetFramework="net46" />
<package id="Microsoft.NET.Test.Sdk" version="17.2.0" targetFramework="net46" />
<package id="NUnit" version="3.5.0" targetFramework="net45" />
<package id="NUnit3TestAdapter" version="4.2.1" targetFramework="net46" />
<package id="NUnit" version="3.14.0" targetFramework="net45" />
<package id="NUnit3TestAdapter" version="4.4.2" targetFramework="net46" />
<package id="Newtonsoft.Json" version="13.0.1" targetFramework="net46" />
</packages>