Fixed issue with empty sample gamAppId #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_gam_app_id
is empty, it correctly defaults to the hardcoded sample gam app id.If the
sample_gam_app_id
is in thegradle.properties
but empty (as it is when you clone for the first time), the app simply crashes becauseorElse
will simply return an empty string.Provider<String>
instead of its value.providers.gradleProperty("sample_gam_app_id").orElse("ca-app-pub-3940256099942544~3347511713")
returns an instance ofProvider<String>
instead of its value asString
. So effectively an instance ofProvider<String>
was being put in themanifestPlaceholders
map, which doesn't sound right.