Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with empty sample gamAppId #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joaocsousa
Copy link

@joaocsousa joaocsousa commented Oct 19, 2023

  1. Fixed issue where if the sample_gam_app_id is empty, it correctly defaults to the hardcoded sample gam app id.

If the sample_gam_app_id is in the gradle.properties but empty (as it is when you clone for the first time), the app simply crashes because orElse will simply return an empty string.

  1. Fixed issue whereby we were setting the manifest placeholder with an instance of a Provider<String> instead of its value.

providers.gradleProperty("sample_gam_app_id").orElse("ca-app-pub-3940256099942544~3347511713") returns an instance of Provider<String> instead of its value as String. So effectively an instance of Provider<String> was being put in the manifestPlaceholders map, which doesn't sound right.

- Fixed issue where if the sample_gam_app_id is empty, it correctly defaults to the hardcoded sample gam app id.
- Fixed issue whereby we were setting the manifest placeholder with an instance of a `Provider<String>` instead of its value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant