Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: requires setuptools-scm #639

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 10, 2024

Coverage Status

coverage: 99.822%. remained the same
when pulling ced6bec on DimitriPapadopoulos:requires_setuptools-scm
into fd8ddee on adrienverge:master.

@adrienverge
Copy link
Owner

About the first commit build: format requires as in setuptools doc, the mentioned documentation shows various examples, including a majority of "one space on each side":

BazSpam == 1.1
pywin32 >= 1.0

Moreover the "one space on each side" style is consistent with the dependencies section. So I propose to drop this change.

About the second commit build: requires setuptools-scm, I'm pretty sure you are right to add it, but I (and potential reviewers of this PR) don't have the reason. Can you document why inside the commit message?
(I see a note about setuptools-scm on https://setuptools.pypa.io/en/latest/userguide/dependency_management.html, but it's not explicit why it would apply to yamllint.)

@DimitriPapadopoulos
Copy link
Contributor Author

I'll drop the first commit.

As for the second commit, I thought setuptools_scm is used by yamllint, but it is not. Maybe an effect of my mixing versions of pip/python?

@DimitriPapadopoulos DimitriPapadopoulos deleted the requires_setuptools-scm branch January 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants