-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (#542): validate ignore-from-file
in validate_rule_conf
#591
Conversation
3ffb4eb
to
f529d95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @ndrwnaguib!
It looks good, please see my comments. Also:
- Could you use the same code style as the rest of the code? (this project doesn't use the Black format)
- This needs a test to make sure the problem won't come back. Can you update
IgnoreConfigTestCase.test_run_with_ignored_from_file()
to include a rule-scopedignore-from-file
like done in theignore
case?
7fbe0a4
to
6545017
Compare
@adrienverge I rebased onto |
809eeca
to
a25fd1c
Compare
This fixes commit 2f8ad70 "config: Implement for `ignore-from-file` option" that lacked rule config validation. Closes adrienverge#542.
a25fd1c
to
36007a2
Compare
Hello, I allowed myself to force-push to your branch because 2 of my requests were not addressed. Also the commit title referenced #524 which is unrelated. I amended that and reworded the commit for better understanding and maintenance. Let's merge now. |
Fix #542. The
ignore-from-file
key wasn't validated invalidate_rule_conf
.