Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#542): validate ignore-from-file in validate_rule_conf #591

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ndrwnaguib
Copy link
Contributor

Fix #542. The ignore-from-file key wasn't validated in validate_rule_conf.

@coveralls
Copy link

coveralls commented Aug 21, 2023

Coverage Status

coverage: 99.397% (+0.001%) from 99.396%
when pulling 36007a2 on ndrwnaguib:fix/issues-542
into 1f79e62 on adrienverge:master.

@ndrwnaguib ndrwnaguib force-pushed the fix/issues-542 branch 4 times, most recently from 3ffb4eb to f529d95 Compare August 22, 2023 02:44
Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @ndrwnaguib!

It looks good, please see my comments. Also:

  • Could you use the same code style as the rest of the code? (this project doesn't use the Black format)
  • This needs a test to make sure the problem won't come back. Can you update IgnoreConfigTestCase.test_run_with_ignored_from_file() to include a rule-scoped ignore-from-file like done in the ignore case?

yamllint/config.py Outdated Show resolved Hide resolved
yamllint/config.py Outdated Show resolved Hide resolved
yamllint/config.py Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
yamllint/config.py Outdated Show resolved Hide resolved
@ndrwnaguib
Copy link
Contributor Author

@adrienverge I rebased onto master using GitHub's update branch button. But, I checked the commit history, I do not see any merge commits, would you like me to drop it and rebase interactively instead?--unless you are going to squash the commits.

This fixes commit 2f8ad70 "config: Implement for `ignore-from-file`
option" that lacked rule config validation.

Closes adrienverge#542.
@adrienverge
Copy link
Owner

Hello,

I allowed myself to force-push to your branch because 2 of my requests were not addressed.

Also the commit title referenced #524 which is unrelated. I amended that and reworded the commit for better understanding and maintenance.

Let's merge now.

@adrienverge adrienverge merged commit ec15376 into adrienverge:master Nov 21, 2023
7 checks passed
@ndrwnaguib
Copy link
Contributor Author

I allowed myself to force-push to your branch because 2 of my requests were not addressed.

That's alright. Sorry about missing them.

Also the commit title referenced #524 which is unrelated. I amended that and reworded the commit for better understanding and maintenance.

Thank you. I meant #542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore-from-file ignored in rule definition
3 participants